CGO: FreeBSD support - Githubissues

alexbrainman / odbc

odbc driver written in go

BSD 3-Clause "New" or "Revised" License

352 stars 140 forks source link

Closed juergenhoetzel closed 6 years ago

juergenhoetzel commented 6 years ago

unixODBC libs/includes are installed under /usr/local via ports/pkg on a FreeBSD system.

juergenhoetzel commented 6 years ago

Looks reasonable. Please make changes as requested, squash commits and I will submit.

Thank you.

Alex

Thanks. I wasn't awe of the perl script. Amended.

alexbrainman commented 6 years ago

I wasn't awe of the perl script. Amended.

You changed the perl script, But you did not run "go generate" command. Don't you want to update zapi_unix.go file to include freebsd?

Alex

juergenhoetzel commented 6 years ago

You changed the perl script, But you did not run "go generate" command

I see. I'm new to the go generate tool and wasn't aware you have to check in the generated file: Amended.

alexbrainman commented 6 years ago

LGTM

Merging now. Thank you very much.

Alex