search

alexbrainman / odbc

odbc driver written in go
BSD 3-Clause "New" or "Revised" License
352 stars 140 forks source link

Add go.mod and go.sum for Go module #126

Closed flibustenet closed 5 years ago

flibustenet commented 5 years ago

Just running go mod init github.com/alexbrainman/odbc and go mod tidy

It could be fine also to release with a semver version.

alexbrainman commented 5 years ago

Thank you.

I do not have time to review this. I will review when I have time.

Alex

wtermini commented 5 years ago

Hi @alexbrainman currently working on a project and would find this change useful. Any chance it could be reviewed?

alexbrainman commented 5 years ago

LGTM Thank you. Sorry for taking too long.

@flibustenet please rebase on master, and I will submit.

currently working on a project and would find this change useful.

@T3RM1NU5 does this change fixes your problem?

Alex

alexbrainman commented 5 years ago

@flibustenet please rebase on master, and I will submit.

Never mind, your commit does not need rebasing. I merged it. So closing this PR now.

Thank you.

Alex

wtermini commented 5 years ago

@alexbrainman and @flibustenet thank you very much for that. Also to answer your question yes it solves my problem. I am working on a build job for my project and I want to make use of Go Modules hence the need mod file.

flibustenet commented 5 years ago

@alexbrainman i thought i did the rebase. I didn't ?

alexbrainman commented 5 years ago

i thought i did the rebase. I didn't ?

I did do rebase. I was mistaken. All is good.

Thank you.

Alex