Closed flibustenet closed 5 years ago
Thank you.
I do not have time to review this. I will review when I have time.
Alex
Hi @alexbrainman currently working on a project and would find this change useful. Any chance it could be reviewed?
LGTM Thank you. Sorry for taking too long.
@flibustenet please rebase on master, and I will submit.
currently working on a project and would find this change useful.
@T3RM1NU5 does this change fixes your problem?
Alex
@flibustenet please rebase on master, and I will submit.
Never mind, your commit does not need rebasing. I merged it. So closing this PR now.
Thank you.
Alex
@alexbrainman and @flibustenet thank you very much for that. Also to answer your question yes it solves my problem. I am working on a build job for my project and I want to make use of Go Modules hence the need mod file.
@alexbrainman i thought i did the rebase. I didn't ?
i thought i did the rebase. I didn't ?
I did do rebase. I was mistaken. All is good.
Thank you.
Alex
Just running
go mod init github.com/alexbrainman/odbc
andgo mod tidy
It could be fine also to release with a semver version.