search

alexcoe / remote-torrent-adder

Automatically exported from code.google.com/p/remote-torrent-adder
0 stars 2 forks source link

multi-server, ruTorrent, bad request #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What version of Chrome are you using? On what operating system?
Version 39.0.2171.42 (64-bit) on Windows 7 SP1 64-bit.

What client (version?) are you connecting to? Are you using SSL?
Version 1.2.0, SSL is on.

What steps will reproduce the problem?
1. Add multiple servers to RTA (set port to 443 and SSL is on)
2. Download using context menu
3. Inspect: RTA is trying to send over HTTP even SSL is on.

Error: "The plain HTTP request was sent to HTTPS port"

What is the expected output? What do you see instead?
RTA should send using HTTPS.

Original issue reported on code.google.com by off...@gmail.com on 5 Nov 2014 at 4:02

GoogleCodeExporter commented 9 years ago 
Line 8 of ruTorrentWebUI.js currently reads:

url += ((server.hostsecure == 'true') ? "s" : "");

Since server.hostsecure is a boolean variable, it should be:

    url += ((server.hostsecure) ? "s" : "");

Original comment by talha.as...@gmail.com on 5 Nov 2014 at 5:13

GoogleCodeExporter commented 9 years ago 
that's quite correct, i broke it by trying to fix it.

can either of you take a look at whether the attached version works? 
instructions are in TryNewCode. i'll push the new version asap if this checks 
out.

Original comment by jul...@gmail.com on 5 Nov 2014 at 6:30

Attachments:

GoogleCodeExporter commented 9 years ago 
Tested and it's working.

Original comment by off...@gmail.com on 5 Nov 2014 at 6:44

GoogleCodeExporter commented 9 years ago 
great, 1.2.1 going out within the hour

Original comment by jul...@gmail.com on 5 Nov 2014 at 6:45