alexdlaird / amazon-orders

A CLI and library for interacting with Amazon order history
https://amazon-orders.readthedocs.io
MIT License
23 stars 9 forks source link

Fix mypy issues. #22

Closed jeffsawatzky closed 1 month ago

jeffsawatzky commented 1 month ago

Description

Fixes the mypy issues.

Type of Change

Testing Done

A clear and concise description of the new tests added to validate the change as well as any manual testing done.

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.31%. Comparing base (517f830) to head (7f9b286). Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
amazonorders/entity/order.py 77.77% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #22 +/- ## =========================================== + Coverage 90.43% 91.31% +0.88% =========================================== Files 16 16 Lines 972 990 +18 =========================================== + Hits 879 904 +25 + Misses 93 86 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexdlaird commented 1 month ago

This is great, thank for taking the time to look at these issues. I had been ignoring them for now, since I disagreed with a lot of the things mypy was saying were "issues", and didn't want to cause regressions diving in to them.

Just a heads up that I won't be able to fully dive in to reviewing this PR for a week or two, very busy right now, and I want to make sure I give it the time it deserves. Thank you in advance for the contribution!

alexdlaird commented 1 month ago

Just a few comments. The primary blocker for me are the assert additions, if you could raise proper exceptions instead. Otherwise the other comments should be trivial fixes, then I'm good to merge. Thanks!

alexdlaird commented 1 month ago

I want to get the changes in develop out ASAP, since Amazon has UI changes coming that are breaking the current implementation, and I want to cut a new release. I plan to merge this PR to develop later tonight, then I will address the comments I left on it before pushing the changes in a release. Thanks for your contribution!