alexdovzhanyn / elixium_core

A privacy-preserving decentralized application network
https://www.elixiumnetwork.org/
281 stars 37 forks source link

Add formatter to the project #33

Closed yordis closed 6 years ago

yordis commented 6 years ago

Probably use Travis for checking that people ran the formatter.

alexdovzhanyn commented 6 years ago

Im not sure I understand. Why do people need to run this formatter?

yordis commented 6 years ago

@alexdovzhanyn because you will no need to discuss about code formatting style, it auto fix your code and you keep consistency in your project.

I notice that you dont like to put parenthesis in functions calls (and that is fine) but Elixir suggest you to put parenthesis on functions calls, but if your habit coming from Ruby is not to use you could relay on mix format to do tedious work for you.

It removes friction pretty much, that is why you would use it, the same with credo.

yordis commented 6 years ago

@alexdovzhanyn check how many parenthesis the formatter added for you because you should be using it on the PR