search

alexdovzhanyn / elixium_core

A privacy-preserving decentralized application network
https://www.elixiumnetwork.org/
281 stars 37 forks source link

For Issue #93 - Update protocol to only send block headers #98

Closed leeaaron629 closed 5 years ago

leeaaron629 commented 5 years ago

I've changed the retrieve_ledger/1 to return a list of block headers instead.

alexdovzhanyn commented 5 years ago

Hey! Sorry for such a late reply, it's been a busy week for me. Thanks for submitting this PR, we really appreciate the contribution.

We should have been more specific about what needed to happen with this Issue -- let me clarify a bit:

In our P2P protocol we're currently sending the entire block to the peer of a node, instead we need to send only the header. To fix this, we just need to update the routing code to send the header instead of the block. The routing code doesn't live in this core repository, it actually lives in the miner and the node codebases. You'll need to update this file to accept incoming block headers and decide whether the whole block needs to be downloaded (if we haven't seen this block before). Then you need to change the broadcast code in the miner after it mines a block to send only the block header to the network.

Let me know if you have any questions!

leeaaron629 commented 5 years ago

No worries. Had a feeling it was the wrong place. I will take a look at it again today