BuildCheckBox Improvements

[dpmurphy]

Make submitForm an user controlled option.

[dpmurphy]

Yes it does

On Mar 5, 2017, at 12:50 PM, Alex Dresko notifications@github.com wrote:

@alexdresko requested changes on this pull request.

The CI build is failing on this PR. Does it compile on your machine?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[alexdresko]

Please try rebuilding the entire solution. I think the HSPIPluginA/B.Dev projects are failing to build.

[dpmurphy]

Ahi Alex, All are rebuilding except this one………..I haven’t pushed the commit button.

C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(1250,5): error MSB3073: The command "powershell -file C:\Users\dmurphy\Documents\Visual Studio 2015\Projects\HSPI\test-template.ps1" exited with code -196608.

The reason I need GetName Public is I have several functions I use a lot - like Log() which write to HS log file and it is in a util.cs - if they were in base then I wouldn’t need this but that might be a longer term solution.

I also have from an original CS plugin example createBasicDevice, CreateChildDevice and CreateRootDevice functions which are also useful and would be used across multiple plugins.

I’ve attached my version - doesn’t compile now but you’ll get the sense of the need.

D.

On Mar 5, 2017, at 2:54 PM, Alex Dresko notifications@github.com wrote:

Please try rebuilding the entire solution. I think the HSPIPluginA/B.Dev projects are failing to build.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alexdresko/HSPI/pull/43#issuecomment-284257238, or mute the thread https://github.com/notifications/unsubscribe-auth/AEgygH8ppQszmbDz-LCuXsOUPV41ySHGks5rixL3gaJpZM4MTduF.

[alexdresko]

Ah, I understand why the ps script is failing now. I'll fix that soon.

Couple things though:

• Can you use the Name property instead of GetName?
• What's in your utility class? Seems like something we could add to HSPI?

[alexdresko]

I fixed the build. Just curious your thoughts on my questions above.

[dpmurphy]

Hi Alex, The attached file, util.cs create....Device functions work well and should just drop into hspiBase, swap Hs for Hs and that should be it.

The Log function relies on a debug setting and so has a dependency I'm not sure how best to address.....

D

On Mar 5, 2017, at 7:36 PM, Alex Dresko notifications@github.com wrote:

I fixed the build. Just curious your thoughts on my questions above.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[alexdresko]

Nothing is attached. If you are replying via email, that won't work for attachments. You'll have to upload it through the web interface.

[alexdresko]

Also, did the Name property work for you?

[dpmurphy]

The devices functions should drop into hspiBase.....

Util.txt