Closed Sonichigo closed 2 months ago
Hi @Sonichigo
This PR is for a product which you're employed to promote as a developer advocate.
If merged, would you update the website to include arkade as the installation method?
Yes we can add on our installation guide that's the plan : - https://keploy.io/docs/server/installation/ . On the main landing page, we are removing the above section with https://github.com/keploy/website/pull/42 section . We initially had kept the get started for just people to try in simple steps.
OK, so you'll need to read the PR template/description carefully and follow the instructions. Once done, let us know.
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.
Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.
This will only take a few moments.
First, clone your fork and checkout this branch using the git CLI.
Next, set up your real name and email address:
git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"
Finally, run one of these commands to add the "Signed-off-by" line to your commits.
If you only have one commit so far then run: git commit --amend --signoff
and then git push --force
.
If you have multiple commits, watch this video.
Check that the message has been added properly by running "git log".
hey @alexellis i'm done please review and let me know if there's any more changes need to be done. This pr resolves #1099
make test
make e2e
in the above i got error:-
Let me ping @Jasstkn / @Shikachuu to have a look a this for you.
@Sonichigo hi. could you follow instructions after the table here and regenerate the table in the README? Overall, changes LGTM 🚀
@Jasstkn done. can you take a look.
I'm sorta kinda still not like the alpha tags but let's roll with this and we'll see.
However can you please do a squash to a single signed commit before we merge this?
Thanks!
I'm sorta kinda still not like the alpha tags but let's roll with this and we'll see.
However can you please do a squash to a single signed commit before we merge this?
Thanks!
I'll keep an eye out with the relase without any alpha or beta tags, once it is released I'll update the version in get file. I think the squash and merge is available from github web interface
I'll keep an eye out with the relase without any alpha or beta tags, once it is released I'll update the version in get file. I think the squash and merge is available from github web interface
If you can squash locally and force push then Derek will remove the no-dco
label
The facility you've provided a screen shot of is only available to the maintainers and they're unlikely to take a further look at PRs where the no-dco
label is showing.
@Shikachuu @rgee0 @Jasstkn closing this pr since lot of commit history is polluated please take a look at this one:- https://github.com/alexellis/arkade/pull/1104
Description
This PR attempts to add support for downloading and installing the
Keploy
for supported platforms (Linux, MacOS, Windows).Motivation and Context
design/approved
by a maintainer (required)How Has This Been Tested?
I have tested on MacOs and WSL (for combined testing for windows and linux)
If updating or adding a new CLI to
arkade get
, run:Types of changes
Documentation
./arkade get --format markdown
./arkade install --help
Checklist:
git commit -s