Enhancement/Fix: Resolve Queue Full Issue in Frame Processing

humayoonsiddiqui commented 10 months ago

Description

This pull request addresses an issue related to the queue becoming full during frame processing in the rtsp-client library. The modifications aim to enhance the stability and reliability of the library, particularly in scenarios where the queue's capacity is reached.

Changes Made

Introduced a timeout mechanism in the push method to handle queue full scenarios.
Utilized the offer method to allow the system to wait for a specified time before considering the queue full.
Implemented logic to clear the queue and interrupt the current thread if the queue size exceeded a predefined threshold.

Version Information

This fork is based on version 2.0.6 of the original repository (alexeyvasilyev/rtsp-client-android:master). The changes made here aim to not only resolve the identified bug but also improve the overall performance of the library.

Why Fork Instead of Wrapping Layer

The nature of the bug required modifications deep within the library's functionality, making a wrapping layer less suitable. Direct changes to the library code were necessary for an effective resolution.

Testing

Include details on any testing performed to validate the changes made in this pull request.

FuadHepa commented 10 months ago

First of all, thank you for this wonderful application

I hope you will make it support GU711A codec audio or help me run it in the application Thank you

humayoonsiddiqui commented 10 months ago

I will not merge this PR. There are too many changes which completely unclear to me. Try to make several PRs isolating the problem you are trying to fix.

I apologize that the PR is currently unclear. I understand that having too many changes can be unClear to review. I'll definitely work on splitting the changes into smaller PRs that isolate the different parts of the problem I'm trying to fix.

FuadHepa commented 10 months ago

First of all, thank you for this wonderful application

I hope you will make it support GU711A codec audio or help me run it in the application Thank you

alexeyvasilyev commented 10 months ago

Will not merge this PR. It is still too big to understand and too many syntax errors. Please make several smaller PRs.

alexeyvasilyev / rtsp-client-android