alexforencich / verilog-ethernet

Verilog Ethernet components for FPGA implementation
MIT License
2.33k stars 707 forks source link

Wrong bit with on 10G MAC Tx start_packet_reg #226

Open drewranck opened 1 month ago

drewranck commented 1 month ago

https://github.com/alexforencich/verilog-ethernet/blob/master/rtl/axis_xgmii_tx_64.v#L174\

Should be reg [1:0]. I noticed this on a private unit simulation I did in Vivado XSIM with a Xilinx GTY. The truncation on [1] on this signal means the 4B misaligned 10G encoding don't report packet starts.

I can fix this if you're willing to take a PR.