search

alexhude / uEmu

Tiny cute emulator plugin for IDA based on unicorn.
1.11k stars 177 forks source link

Add IDA 7.1 support and ARM64 bugfixes #7

Closed bkerler closed 6 years ago

bkerler commented 6 years ago

Attention : This commit breaks support for IDA < 7.1. So I strongly recommend to add it to a new base like "IDA 7.1".

alexhude commented 6 years ago

Sorry, mate, I can't merge this PR. It is not backwards compatible which is important for some people. Good catch with false thumb detection for ARM64 but regarding refresh - I am not so sure, need to test. SetColor is doing refresh itself and I don't want to refresh entire view for every step. By the way, I am working on 7.1 support already. Eta son.

bkerler commented 6 years ago

I broke backwards compatibility because the ida python sdk changed in 7.1 a lot (functions names, imports) and will even change more with 7.2, adding older versions causes additional exception handling which makes the codes very unreadable (and might tend to crash more). For example refreshing the screen in < 7.1 doesn't make any sense because it burns a lot of resources but with > 7.1 screen stays blank if you don't do after stepping. Of course it is doable to add backwards compatibility, but it does make more sense to make a new branch for at least every new ida api rewrite.