search

alexpghayes / distributions3

Probability Distributions as S3 Objects
https://alexpghayes.github.io/distributions3/
Other
100 stars 16 forks source link

Update HurdlePoisson.R documentation #94

Closed dkwhu closed 2 years ago

dkwhu commented 2 years ago

edited the formula for c.d.f.: 1) updated the numerator of the last term to "(F(k; \lambda) - F(0; \lambda))" ; 2) updated P(X = k) to P( X \le k)

zeileis commented 2 years ago

Thanks @dkwhu for spotting and correcting this!

Alex @alexpghayes, this looks good to me. We also have to make the same change in HurdleNegativeBinomial.R (copy & paste error). Should I go ahead with approving the workflow and, if successful, merging the PR, or do you prefer to do that? (Both fine with me!)

alexpghayes commented 2 years ago

Should I go ahead with approving the workflow and, if successful, merging the PR, or do you prefer to do that? (Both fine with me!)

Take on as much maintenance as you would like!! I won't complain :)

zeileis commented 2 years ago

Thanks, Alex, will do. (And if I'm exceeding my responsibilities anywhere, please just let me know...)