alexrothenberg / motion-addressbook

MIT License
89 stars 30 forks source link

Person not returned when selected from Addressbook picker in iOS8 #69

Open danielsettanni opened 10 years ago

danielsettanni commented 10 years ago

I noticed that the Addressbook picker wasn't working as expected in iOS 8. Instead of returning to my app when I selected a contact I was taken to the contact details page and if I selected a contact method (i.e. phone number, email address, etc) I was taken to the default iOS action instead of back to my app. After a little digging it appears that there are two new methods for the delegate in iOS 8 that are needed:

def peoplePickerNavigationController(people_picker, didSelectPerson:ab_person)
  hide(ab_person)
  false
end

def peoplePickerNavigationController(people_picker, didSelectPerson:ab_person, property:property, identifier:id)
  hide(ab_person)
  false
end

Once these are added iOS 8 works as expected.

iwarshak commented 10 years ago

@danielsettanni any chance you could create a pull req for this so that @alexrothenberg can pull it in?

danielsettanni commented 10 years ago

Hi Ian,

I just created a pull request. I apologize - I've never contributed to github before and thought I had already done this.

Thanks, Daniel

On Oct 16, 2014, at 9:25 PM, Ian Warshak notifications@github.com wrote:

@danielsettanni any chance you could create a pull req for this so that @alexrothenberg can pull it in?

— Reply to this email directly or view it on GitHub.

iwarshak commented 10 years ago

Thanks @danielsettanni !