alfred-leong / pe

0 stars 0 forks source link

Tampering with data file not detected #15

Open alfred-leong opened 1 year ago

alfred-leong commented 1 year ago

Normally, during the program execution, special characters like '@' are not allowed as part of the patient's ID as seen below.

image.png

However, after tampering with the data file and adding special characters, it was not detected and the file loaded fine.

image.png

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Editing patients.txt file does not check for input restrictions.

Added a new patient with 3 words in her name, as shown below. Then I saved the file and restarted the program. image.png

According to the User Guide,

image.png

However, according to the screenshot beloww, the program reads it as a valid name despite the UG. image.png

If I were to add another user with 3 words in her name using the add command, the program will show an error. This would result in inconsistent data. image.png


[original: nus-cs2113-AY2223S1/pe-interim#537] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Should have performed better checks during loading of patients from storage.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]