algirdasc / expensave

Personal and family expense tracking and budgeting application, enabling better financial management
GNU General Public License v3.0
2 stars 1 forks source link

feature: select default calendar #18

Closed algirdasc closed 5 months ago

algirdasc commented 5 months ago

Summary by CodeRabbit

algirdasc commented 4 months ago

@coderabbitai review

coderabbitai[bot] commented 4 months ago
Actions Performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 4 months ago
Walkthrough ## Walkthrough The recent updates introduce a feature to set a default calendar for users. This involves backend changes, including a new migration to add a `default_calendar_id` column to the `user` table and updates to the `User` entity. On the frontend, new methods and properties were added to handle the default calendar functionality, including UI updates to allow users to set a default calendar via the interface. ## Changes | File(s) | Change Summary | |------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `backend/migrations/Version20240422083558.php` | Added a migration script to include a `default_calendar_id` column in the `user` table and its rollback operation. | | `backend/src/Const/AssertConst.php` | Introduced a new constant `MSG_DEFAULT_CALENDAR_USER_MISMATCH` with the message 'This calendar owned by other user'. | | `backend/src/Controller/User/ProfileController.php` | Added a method `defaultCalendar` to set the default calendar for a user by updating the user's default calendar ID in the database. | | `backend/src/Entity/User.php` | Added a new property `$defaultCalendarId` with corresponding getter and setter methods, including ORM metadata for column mapping and serialization groups. | | `frontend/src/app/api/objects/calendar.ts` | Updated `isOwner` method to check for the existence of `this.owner.id` before comparison and added a new method `isDefault` to check if a user's default calendar ID matches the calendar's ID. | | `frontend/src/app/api/objects/user.ts` | Added a new public property `defaultCalendarId` of type `number` to the `User` class. | | `frontend/src/app/api/user.api.service.ts` | Added a `defaultCalendar` method to the `UserApiService` class for setting a default calendar. | | `frontend/src/app/modules/main/main.component.ts` | Updated the logic for setting the `calendar` property in `mainService` to filter the `calendars` array based on the `defaultCalendarId` of the user. | | `frontend/src/app/modules/main/sidebar/calendar-list/calendar-list.component.html` | Enhanced the UI to include a button for setting a calendar as default with a heart icon and modified the visibility of "Edit calendar" and "Delete calendar" buttons based on calendar ownership. | | `frontend/src/app/modules/main/sidebar/calendar-list/calendar-list.component.scss` | Adjusted the width property for the `.calendar-actions` class under `label` in the host element from `width: 120px;` to `max-width: 140px;`. | | `frontend/src/app/modules/main/sidebar/calendar-list/calendar-list.component.ts` | Added `UserApiService` import, `userApiService` property, and `makeDefault` method to set a calendar as default. |

[!TIP]

New Features and Improvements ## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
algirdasc commented 4 months ago

@coderabbitai read backend/src/Controller/User/ProfileController.php and generate unit testing code.

coderabbitai[bot] commented 4 months ago

[!TIP] For best results, initiate chat on the files or code changes.

@algirdasc, here's the unit testing code for the ProfileController class based on the methods it contains:

<?php

use PHPUnit\Framework\TestCase;
use App\Controller\User\ProfileController;
use App\Entity\User;
use App\Entity\Calendar;
use App\Repository\UserRepository;
use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\Security\Http\Attribute\CurrentUser;

class ProfileControllerTest extends TestCase
{
    private $controller;
    private $userRepositoryMock;
    private $passwordHasherMock;

    protected function setUp(): void
    {
        $this->userRepositoryMock = $this->createMock(UserRepository::class);
        $this->passwordHasherMock = $this->createMock(UserPasswordHasherInterface::class);
        $this->controller = new ProfileController($this->userRepositoryMock, $this->passwordHasherMock);
    }

    public function testList()
    {
        $this->userRepositoryMock->method('findBy')->willReturn([]);
        $response = $this->controller->list();
        $this->assertInstanceOf(JsonResponse::class, $response);
    }

    public function testProfile()
    {
        $user = new User();
        $this->userRepositoryMock->method('find')->willReturn($user);
        $response = $this->controller->profile($user);
        $this->assertInstanceOf(JsonResponse::class, $response);
    }

    public function testChangePassword()
    {
        $user = new User();
        $request = new PasswordChangeRequest();
        $request->setCurrentPassword('oldPassword');
        $request->setNewPassword('newPassword');

        $this->passwordHasherMock->method('isPasswordValid')->willReturn(true);
        $this->userRepositoryMock->expects($this->once())->method('save');

        $response = $this->controller->changePassword($user, $request);
        $this->assertInstanceOf(JsonResponse::class, $response);
    }

    public function testDefaultCalendar()
    {
        $user = new User();
        $calendar = new Calendar();
        $calendar->setId(1);

        $this->userRepositoryMock->expects($this->once())->method('save');
        $response = $this->controller->defaultCalendar($user, $calendar);
        $this->assertInstanceOf(JsonResponse::class, $response);
    }
}

This code includes basic unit tests for each method in the ProfileController. You can extend these tests by adding more detailed scenarios and assertions as needed.

Analysis chain
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Fetch the content of ProfileController.php cat backend/src/Controller/User/ProfileController.php ``` Length of output: 2412