search

algolia / algoliasearch-client-javascript

⚡️ A fully-featured and blazing-fast JavaScript API client to interact with Algolia.
https://www.algolia.com/doc/api-client/javascript/getting-started/
MIT License
1.33k stars 221 forks source link

feat(types): add hide in renderingContent facet values #1529

Closed thomasbritton closed 2 months ago

thomasbritton commented 2 months ago

Adds typing for the new hide property in renderingContent facet values

JIRA ticket: https://algolia.atlassian.net/browse/EMERCH-1518

thomasbritton commented 2 months ago

The failing tests seem unrelated, are they flakey?

thomasbritton commented 2 months ago

Looks good ! And yes the tests are flakey @thomasbritton, gotta rerun them :/

I have re-run 5 times not passing still @aymeric-giraudet

shortcuts commented 2 months ago

hey @thomasbritton yes it fails aaaa looooot (can't wait to move to https://github.com/algolia/api-clients-automation), it might not be flakiness at this point, I think something is broken, i'll try to fix it on monday

thomasbritton commented 2 months ago

hey @thomasbritton yes it fails aaaa looooot (can't wait to move to https://github.com/algolia/api-clients-automation), it might not be flakiness at this point, I think something is broken, i'll try to fix it on monday

Hey @shortcuts , I'm trying it once more for luck! But thank you for your support on this.

thomasbritton commented 2 months ago

Hey @shortcuts , just wondering if you have been able to have a look at this yet?

shortcuts commented 2 months ago

trying right now