algolia / search-insights-gtm

Google Tag Manager template for detecting front-end Algolia search metrics
Apache License 2.0
6 stars 5 forks source link

fix:changing regex to allow 0 in the queryID #9

Closed matthewbond closed 3 years ago

matthewbond commented 3 years ago

The regex for query id will not match query ids which contain a 0:

https://regex101.com/r/dVJKLw/1

Screenshot 2021-08-31 at 18 18 11

I think we need to change the regex to allow a 0:

https://regex101.com/r/40yYZX/1

Screenshot 2021-08-31 at 18 18 02
rayrutjes commented 3 years ago

Does it or should we allow capital letters?

matthewbond commented 3 years ago

@rayrutjes From what I can see here the queryID does not contain capital letters, I did some test searches and indeed the letters were all lowercase.

rayrutjes commented 3 years ago

Indeed and it's properly documented in lowercase!

matthewbond commented 3 years ago

thanks @rayrutjes and @tkrugg !