algora-io / tv

Open source Twitch for developers
https://algora.tv
Other
1.07k stars 67 forks source link

Choose thumbnail UI #108

Closed gilest closed 1 month ago

gilest commented 1 month ago

Part 2/2 of https://github.com/algora-io/tv/issues/81

/claim #81

This branch includes commits from algora-io/tv/pull/106 until that's merged – compare view of commits for the UI feature only

I'm new to Elixir/LV so feedback appreciated

https://github.com/user-attachments/assets/1afb23ae-5008-43b3-bd07-9de97668ded4

algora-pbc[bot] commented 1 month ago

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

gilest commented 1 month ago

@zcesur Thanks for your review. I have addressed your comments

gilest commented 1 month ago

Thanks for your review, @zcesur

  • Let's add on_conflict: :nothing to thumbnail inserts (otherwise it crashes the pipeline)
  • Let's keep index-0.jpeg as the thumbnail unless the user manually changes it (otherwise user's choice is overwritten as new thumbnails are generated)

Good calls. Implemented upstream in #106

  • Let's hide the "Choose thumbnail" for users who are neither creator of the video nor admin

Have done so here

gilest commented 1 month ago

Hi @zcesur is there anything outstanding on my end, here?

zcesur commented 1 month ago

Looks great, thanks!

zcesur commented 1 month ago

We can proceed with the bounty payout once you finalize your Stripe account creation @gilest

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

gilest commented 1 month ago

We can proceed with the bounty payout once you finalize your Stripe account creation @gilest

Thanks! Believe my Stripe account is linked now