search

algorandfoundation / algokit-utils-ts

MIT License
19 stars 8 forks source link

fix: resource population bugs #278

Closed joe-p closed 6 months ago

joe-p commented 6 months ago

Proposed Changes

Fixes two bugs on resource population

  1. Pushing a resource to an undefined array doesn't actually work

  2. Box references weren't checking if the app was available

joe-p commented 6 months ago

@robdmoore We're seeing the indexer tests timeout and I'm also seeing the same locally since I've updated my localnet. I know we've talked about this before but forget what the reasoning was and how we might reasonably fix this

robdmoore commented 6 months ago

There's some quite complex logic here that it may make sense to have test coverage for, but on the other hand I know this logic will move to algod at some point so probably time better spent adding test coverage there when that happens?

robdmoore commented 6 months ago

@joe-p https://github.com/algorand/indexer/issues/1613

joe-p commented 6 months ago

There's some quite complex logic here that it may make sense to have test coverage for, but on the other hand I know this logic will move to algod at some point so probably time better spent adding test coverage there when that happens?

Yeah that's exactly what I'm thinking. Will start algod effort this week so didn't want to spend time writing the tests here. I've confirmed that this works in the reti ui.