ali5h / rules_pip

pip package rules for bazel that are fast (incremental fetch), support different python versions and work with all kinds of packages (i.e. packages with namespaces)
MIT License
60 stars 23 forks source link

Fix mistake in overrides #73

Closed fahhem closed 2 years ago

fahhem commented 2 years ago

Sorry for that!

ali5h commented 2 years ago

what is fixed?

fahhem commented 2 years ago

It turns out this wasn't working at all, I'll add a test that overrides pytz with something different and ensure it's not actually pytz

fahhem commented 2 years ago

okay, it's ready!

fahhem commented 2 years ago

@ali5h Any chance you have time to review this? I'm in no rush, we're using this branch internally and it's working great, but I figured since the feature's broken and part of the last release, it would be good to get this in and make a new release