alibaba / libgrape-lite

🍇 A C++ library for parallel graph processing (GRAPE) 🍇
https://alibaba.github.io/libgrape-lite/
Apache License 2.0
395 stars 93 forks source link

Fix missing assignment operator for Bitset #155

Closed songqing closed 1 year ago

songqing commented 1 year ago

What do these changes do?

In PR #154 and #149, copy and move ctor for Bitset are added, however, the assignment operator is not added, and there will be compile error, see follow.

f2 f3
codecov-commenter commented 1 year ago

Codecov Report

Merging #155 (78f81a0) into master (45281c4) will not change coverage. Report is 4 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155/graphs/tree.svg?width=650&height=150&src=pr&token=Jwwd96nVmz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba)](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) ```diff @@ Coverage Diff @@ ## master #155 +/- ## ======================================= Coverage 63.96% 63.96% ======================================= Files 67 67 Lines 6310 6310 ======================================= Hits 4036 4036 Misses 2274 2274 ``` | [Flag](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) | Coverage Δ | | |---|---|---| | [app_tests](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) | `63.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba) | Coverage Δ | | |---|---|---| | [grape/utils/bitset.h](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-Z3JhcGUvdXRpbHMvYml0c2V0Lmg=) | `75.00% <ø> (ø)` | | | [grape/utils/concurrent\_queue.h](https://app.codecov.io/gh/alibaba/libgrape-lite/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alibaba#diff-Z3JhcGUvdXRpbHMvY29uY3VycmVudF9xdWV1ZS5o) | `90.62% <ø> (ø)` | |