Closed George5814 closed 8 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
0807185
) 53.17% compared to head (232f7a5
) 53.42%.:exclamation: Current head 232f7a5 differs from pull request most recent head dd69039. Consider uploading reports for the commit dd69039 to get more accurate results
Files | Patch % | Lines |
---|---|---|
core/log/metric/writer.go | 90.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Describe what this PR does / why we need it
impove sentinel latest metric log file name to xxx-metrics.log.
Fix the latest file name format for convenient log collection.
Does this pull request fix one issue?
NONE
Describe how you did it
nextFileNameOfTime
with funcrotateWithDateAndNewFileName
latestOpSec
before roll log file when app startingDescribe how to verify it
The implementation can be verified via go test.
Special notes for reviews