search

alibgang / FagottinoSite

SCB - FagottinoSite
1 stars 0 forks source link

Update Measurements.html with WIP msg #24

Open alibgang opened 6 years ago

alibgang commented 6 years ago

Add the following to the body to set WIP status on this page: "The links to our measurement/photo databases are not yet in place and we are working to present this information as soon as possible. In the meantime, please contact us if you wish to receive detailed measurements and/or photos of specific instruments. Thank you.”

alibgang commented 6 years ago

Added 11/22/18 and verified locally. Will verify when VPS is running.

alibgang commented 6 years ago

Measurements link in menu still isn't showing. Need to check with Colby when he's back.

colbynh commented 6 years ago

HI Alison am I correct in assuming that this merge contains the code for this update ? https://github.com/alibgang/FagottinoSite/commit/3f3a47a5d76aa7ec426bd4f26779bdf97b41601f

colbynh commented 6 years ago

If the measurements code on master is latest that is what is deployed to the VPS as of last night.

`commit 3f3a47a5d76aa7ec426bd4f26779bdf97b41601f (HEAD -> master, origin/master, origin/HEAD) Merge: a52827e bdc11fa Author: A. G alibgang@users.noreply.github.com Date: Thu Nov 22 22:24:46 2018 -0500

Merge pull request #22 from alibgang/update-htmlpages

Update htmlpages`

That is the git log directly from the vps itself. We may need to run the stack locally and debug as there might be a bug with the measurements page. Please investigate further.

colbynh commented 6 years ago

I also notice that there is error when loading the page. It failing to load a static asset which could be causing it to default back to the original 'under construction page'

GET http://209.182.217.104:8000/static/assets/images/rp-1.jpg 404 (Not Found)

alibgang commented 6 years ago

When I go to the VPS, I don’t see the option to select the Measurements page in the menu. The citing page is throwing a 500 error on stg but not on my local system. The code in the merge is the same as is running correctly on my local system. The measurements page has NO dynamic content currently in the head of the Master branch. Will only be able to look further at this later this evening.

colbynh commented 6 years ago

Oh it's totally missing from the menu??

On Sat, Nov 24, 2018, 12:19 PM A. G. <notifications@github.com wrote:

When I go to the VPS, I don’t see the option to select the Measurements page in the menu. The citing page is throwing a 500 error on stg but not on my local system. The code in the merge is the same as is running correctly on my local system. The measurements page has NO dynamic content currently in the head of the Master branch. Will only be able to look further at this later this evening.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alibgang/FagottinoSite/issues/24#issuecomment-441382358, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7WkgcHQgSBEJSgh8uHeOoGzGRDnLAfks5uyX-9gaJpZM4YwxbU .

alibgang commented 6 years ago

Yep

colbynh commented 6 years ago

Okay is there also another measurements page as well that I am thinking of? The one you click currently that says under construction?

On Sat, Nov 24, 2018, 12:23 PM A. G. <notifications@github.com wrote:

Yep

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alibgang/FagottinoSite/issues/24#issuecomment-441382541, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7WkpJi3gXbAhVfriYLIEP_AMqCsFtuks5uyYB2gaJpZM4YwxbU .

alibgang commented 6 years ago

The measurements view in views.py only points to measurements.html and this html page is the only one that gets used from the menu; it currently contains static content only (in the % content block % section) and NO dynamic content. What’s showing in the merge is the same as what works on my local system.

colbynh commented 6 years ago

Okay I understand. We will have to SSH into the running container to see what code it is actually pointing to.

On Sat, Nov 24, 2018, 12:28 PM A. G. <notifications@github.com wrote:

The measurements view in views.py only points to measurements.html and this html page is the only one that gets used from the menu; it currently contains static content only (in the % content block % section) and NO dynamic content. What’s showing in the merge is the same as what works on my local system.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alibgang/FagottinoSite/issues/24#issuecomment-441382861, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7Wktc6-fvH_WH0PC7luLNMNgA-w1tNks5uyYGxgaJpZM4YwxbU .

colbynh commented 6 years ago

If it's working locally, I presume I must have made a misstep during the deployment.

On Sat, Nov 24, 2018, 12:48 PM Colby Chenard <guitaristcolby@gmail.com wrote:

Okay I understand. We will have to SSH into the running container to see what code it is actually pointing to.

On Sat, Nov 24, 2018, 12:28 PM A. G. <notifications@github.com wrote:

The measurements view in views.py only points to measurements.html and this html page is the only one that gets used from the menu; it currently contains static content only (in the % content block % section) and NO dynamic content. What’s showing in the merge is the same as what works on my local system.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alibgang/FagottinoSite/issues/24#issuecomment-441382861, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7Wktc6-fvH_WH0PC7luLNMNgA-w1tNks5uyYGxgaJpZM4YwxbU .

colbynh commented 6 years ago

Because the deployed code should be the head revision of master branch.

On Sat, Nov 24, 2018, 12:50 PM Colby Chenard <guitaristcolby@gmail.com wrote:

If it's working locally, I presume I must have made a misstep during the deployment.

On Sat, Nov 24, 2018, 12:48 PM Colby Chenard <guitaristcolby@gmail.com wrote:

Okay I understand. We will have to SSH into the running container to see what code it is actually pointing to.

On Sat, Nov 24, 2018, 12:28 PM A. G. <notifications@github.com wrote:

The measurements view in views.py only points to measurements.html and this html page is the only one that gets used from the menu; it currently contains static content only (in the % content block % section) and NO dynamic content. What’s showing in the merge is the same as what works on my local system.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alibgang/FagottinoSite/issues/24#issuecomment-441382861, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7Wktc6-fvH_WH0PC7luLNMNgA-w1tNks5uyYGxgaJpZM4YwxbU .

colbynh commented 6 years ago

Hi Alison, Now that I am on my computer, taking a closer look. I have noticed you said "The measurements view in views.py only points to measurements.html". However if I do a search on the current code committed to the master branch

screen shot 2018-11-25 at 12 47 19 am

I do not see that there is a reference to measurements.html. I think that maybe you either locally committed and unpushed or uncommitted changes locally to views.py for that reference. I will go in and try add the reference myself in the running container and restart just to see if that fixes it. But check to see if maybe you didnt commit or you didnt push to github or something like that.