Closed tdg5 closed 1 year ago
Merging #78 (29dc2bb) into master (c6ddffa) will decrease coverage by
0.57%
. The diff coverage is75.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 98.80% 98.24% -0.57%
==========================================
Files 14 14
Lines 669 683 +14
Branches 102 106 +4
==========================================
+ Hits 661 671 +10
- Misses 4 8 +4
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
aioauth/utils.py | 97.75% <ø> (ø) |
|
aioauth/server.py | 97.05% <50.00%> (-2.95%) |
:arrow_down: |
aioauth/errors.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Sorry for pushing a bunch of late commits to this PR. I am satisfied with what's here now :+1:
Sorry for pushing a bunch of late commits to this PR. I am satisfied with what's here now 👍
merging then :)
Believe it or not, this is the beginning of working to make it so the password grant doesn't require a
client_secret
.In broad strokes, this aims to make the setting of the
WWW-Authenticate
header the responsibility of theInvalidClientError
instead of being the responsibility of theget_client_credentials
function.EDIT: I was going to make
client_secret
optional for the password grant in another PR, but it doesn't seem like there's enough extra code required to warrant that. So this now includes logic to make it so the password grant type doesn't require aclient_secret
. Viewing the changes by commit may help disentangle things.