Added count fails

[aligrudi]

Stefan @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/aligrudi/neatvi/pull/45

-- Commit Summary --

• Added count fails

-- File Changes --

M test.sh (4)

-- Patch Links --

https://github.com/aligrudi/neatvi/pull/45.patch https://github.com/aligrudi/neatvi/pull/45.diff

Thanks for the patch.

Given that even a single failure is unacceptable, how about stopping at the first failure instead?

Something like this patch:

diff --git a/test.sh b/test.sh index 28e9a48..b2b3d4b 100755 --- a/test.sh +++ b/test.sh @@ -1,15 +1,23 @@

!/bin/sh

+testcase() {

• if ! cmp -s /tmp/.neatvi[12]; then
• echo "Failed"
• diff -u /tmp/.neatvi[12]
• exit 1
• fi +}

• for x in test/e??.sh; do rm -f /tmp/.neatvi[12]

• echo -n "$x: " sh $x /tmp/.neatvi2 2>/tmp/.neatvi1 | ./vi -s -e >/dev/null
• cmp -s /tmp/.neatvi[12] || echo "Failed: $x"
• cmp -s /tmp/.neatvi[12] || diff -u /tmp/.neatvi[12]

• testcase /tmp/.neatvi[12] && echo "OK" done

  for x in test/v??.sh; do rm -f /tmp/.neatvi[12]

• echo -n "$x: " sh $x /tmp/.neatvi2 2>/tmp/.neatvi1 | ./vi -v >/dev/null
• cmp -s /tmp/.neatvi[12] || echo "Failed: $x"
• cmp -s /tmp/.neatvi[12] || diff -u /tmp/.neatvi[12]
• testcase /tmp/.neatvi[12] && echo "OK" done

[polluks]

I see, one function is better than three cmp's. However without exit you get some kind of overview.

[aligrudi]

Stefan @.***> wrote:

I see, one function is better than three cmp's. However without exit you get some kind of overview.

Before, I usually searched the output for the first failure to fix. Now, that would be much easier.

I have applied a cleaned up version of this patch. Please report if there is a problem.

Thanks, Ali