search

alingse / sundrylint

three thousand real world bug linter
MIT License
5 stars 0 forks source link

Could you please use PR and a branch for your own commits #8

Closed ccoVeille closed 4 months ago

ccoVeille commented 4 months ago

Hi @alingse

I saw you started working on "regexp.MustCompile out", I'm really happy about that.

But I would like you to use a branch and open a PR, so watchers (maybe only me for now) could follow and review your work.

Thanks

alingse commented 4 months ago

@ccoVeille sure, I will use PR to update the code.

but regexp.MustCompile in func is a common usage 😂 , it's hard to move it out see https://github.com/alingse/sundrylint/issues/7 , I only found one repo worth to change

ccoVeille commented 4 months ago

Could you please provide me the link to the repository ypu are a talking about?

It's uneasy to find in it among the 600+ comments. At least, when you don't know what to look for 😅

alingse commented 4 months ago

Could you please provide me the link to the repository ypu are a talking about?

It's uneasy to find in it among the 600+ comments. At least, when you don't know what to look for 😅

sorry for not mentioned in last comment, I mean https://github.com/redis/go-redis/pull/3280

many people use regexp.MustCompile every where, it's hard to check the function is frequently called or not. Only when it was called many times, it might worth to move regexp.MustCompile out.

so I give up this idea.