Closed alistairjcbrown closed 6 days ago
Working on 1 and 2 -- all requests are now being made inside of the retrieve function. Tests are being put in place, recording request repsonses and snapshotting output. This will let us refactor code, knowing that given the same input we'll get the same output. Once this is in place, we can complete 2 by refactoring code to make it a) more simple and b) more standardised
Once it's all in a good place, we can enhance the code as per 3 and add new data!
Just further updates for data retrieval required -- about hafl way so far
Sites remaining to update for status and accessibility:
cinemas/genesiscinema.co.uk/transform.js
cinemas/princecharlescinema.com/transform.js
cinemas/richmix.org.uk/transform.js
cinemas/thecastlecinema.com/transform.js
cinemas/thegardencinema.co.uk/transform.js
cinemas/thelexicinema.co.uk/transform.js
common/myvue.com/transform.js
sources/eventbrite.co.uk/find-events.js
Before doing https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/39, let's get the code in a better place
This work will cover https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/14, https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/44, https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/20 and some of https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/42
The goals for this are to:
By the end, we should have all cinema modules reviewed, relatively similar approaches (where it makes sense), and with all available data being retrieved so that we can do clever things in the future, like https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/42