alistairjcbrown / hackney-cinema-calendar

Automatically generated calendar of events for cinemas in Hackney, London
MIT License
0 stars 0 forks source link

Review all cinema code and improve data retrieval #45

Closed alistairjcbrown closed 6 days ago

alistairjcbrown commented 2 weeks ago

Before doing https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/39, let's get the code in a better place

This work will cover https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/14, https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/44, https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/20 and some of https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/42

The goals for this are to:

  1. Standardise approach and naming acrosss all modules
  2. Have a good separation of getting data vs transforming datra
  3. Make sure we're getting all the data available -- historically when this was for the calendar only, harder to get data was punted on

By the end, we should have all cinema modules reviewed, relatively similar approaches (where it makes sense), and with all available data being retrieved so that we can do clever things in the future, like https://github.com/alistairjcbrown/hackney-cinema-calendar/issues/42

alistairjcbrown commented 2 weeks ago

Working on 1 and 2 -- all requests are now being made inside of the retrieve function. Tests are being put in place, recording request repsonses and snapshotting output. This will let us refactor code, knowing that given the same input we'll get the same output. Once this is in place, we can complete 2 by refactoring code to make it a) more simple and b) more standardised

Once it's all in a good place, we can enhance the code as per 3 and add new data!

alistairjcbrown commented 1 week ago

Just further updates for data retrieval required -- about hafl way so far

alistairjcbrown commented 1 week ago

Sites remaining to update for status and accessibility: