aliyun / plugsched

Live upgrade Linux kernel scheduler subsystem
BSD 3-Clause "New" or "Revised" License
82 stars 23 forks source link

src: fix invalid symbol reference when using __mod_ prefix #133

Closed chenshanpei closed 2 years ago

chenshanpei commented 2 years ago

There's a potential problem. If we declare 'extern int __mod_xxx' in main.c, but xxx doesn't exist in the module. Then __mod_xxx will refer to xxx in vmlinux eventually.

This patch fix it by checking whether symbol xxx exist in scheduler module.

Fixes: 00fa01c ("src: support for accessing static symbol with _mod prefix") Signed-off-by: Shanpei Chen shanpeic@linux.alibaba.com

anolis-bot commented 2 years ago

@chenshanpei , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/2r1b4c7z/test_result/18915

anolis-bot commented 2 years ago

@chenshanpei , The CI test is completed, please check result:

Test CaseTest Result
plugsched-citestx86_64:x: FAIL
plugsched-citestaarch64:x: FAIL

Sorry, your test job failed. Please get the details in the link.

chenshanpei commented 2 years ago

/retest

anolis-bot commented 2 years ago

@chenshanpei , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/2r1b4c7z/test_result/18950

anolis-bot commented 2 years ago

@chenshanpei , The CI test is completed, please check result:

Test CaseTest Result
schedule_testx86_64:white_check_mark: SUCCESS
public_var_test:white_check_mark: SUCCESS
var_uniformity_test:white_check_mark: SUCCESS
cpu_throttle_test:white_check_mark: SUCCESS
domain_rebuild_test:white_check_mark: SUCCESS
sched_syscall_test:white_check_mark: SUCCESS
mem_pressure_test:white_check_mark: SUCCESS
plugsched-citestaarch64:x: FAIL

Sorry, your test job failed. Please get the details in the link.