allegro / grunt-maven-plugin

Grunt + Maven integration done right
Other
213 stars 32 forks source link

missing dependency: junction #31

Closed yagee-de closed 10 years ago

yagee-de commented 10 years ago

When trying to run the sample code I get this error message:

Execution default of goal pl.allegro:grunt-maven-plugin:1.2.1:create-resources failed:
Plugin pl.allegro:grunt-maven-plugin:1.2.1 or one of its dependencies could not be resolved:
Failure to find sysinternals:junction:exe:1.04

As I use Linux I wonder, why I need an EXE file. Beside that missing dependency stops me from execute this plugin.

adamdubiel commented 10 years ago

"exe" has nothing to do with operating system, it's just what this plugin downloads always. I just rebuilt sandbox project after cleaning local m2 repo and all went fine.. It downloads this artifact from:

http://www.pyx4me.com/maven2/sysinternals/junction/1.04/junction-1.04.exe

try if direct link works for you. If not, I can consider making this dependency "provided", as linking feature is probably used by small percent of grunt-maven-plugin users.

yagee-de commented 10 years ago

"provided" does not work, but:

  <pluginRepositories>
    <pluginRepository>
      <id>pyx4me</id>
      <url>http://www.pyx4me.com/maven2/</url>
    </pluginRepository>
  </pluginRepositories>

works.

adamdubiel commented 10 years ago

Did you add provided in grunt-maven-plugin pom?

It should look like this:

<dependency>
    <groupId>com.pyx4j</groupId>
    <artifactId>maven-junction-plugin</artifactId>
    <version>1.0.3</version>
    <scope>provided</scope>
</dependency>

I will test this and if it works i will create new release with updated readme. Making this optional is a good idea, this junction plugin it has some strange dependencies.

yagee-de commented 10 years ago

You may not have scope "provided" within dependencies of a plugin, only "compile", "runtime" and "system" are allowed. If it were optional one could add it as a dependency but you sadly cannot exclude it.

adamdubiel commented 10 years ago

Okay, i didn't know that, but it makes sense. It's weird that maven couldn't resolve this dependency without pointing to pyx4j repo though, no one reported this earlier and i didn't have problems building projects on different CI servers as well.

adamdubiel commented 10 years ago

Since 1.2.2 using junction plugin is no longer recommended, so probably in 1.3.x support for it will be removed in favor of npm-offline goal. Closing this issue.

cliffsun91 commented 10 years ago

I know this is closed, but I'm getting this issue too and can't seem to resolve it. I have the junction.exe artifact uploaded to our local maven repository (and I can navigate to it fine via url), however I keep on getting the 'Failure to find sysinternals:junction:exe:1.04' problem.

Has anyone else had problems resolving this issue?

adamdubiel commented 10 years ago

I will prepare 1.3 release that will deprecate this plugin. It seems this becomes bit of an issue, so i might do it tomorrow.

adamdubiel commented 10 years ago

1.3 is now waiting to be transferred to maven central.