search

allegroai / clearml-server

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution
https://clear.ml/docs
Other
386 stars 134 forks source link

[UI] Bring back single click on experiment to get into details view #134

Open mctigger opened 2 years ago

mctigger commented 2 years ago

With version 1.4 of clearml-server left-click on an experiment opens a context menu instead of the details view. We already have right-click for the context menu, so bring back left-click for details :)

(I know you can now toggle views on the top, but I liked being in the list view and getting into the details view on click)

ainoam commented 2 years ago

@mctigger We realize new UX might take some getting used to :) There're actually a few use cases that all connected with this new change. Appreciate if you can provide additional feedback after playing with the new version for a few days.

idantene commented 2 years ago

I understand the new UX, but it would be nice if this feature was toggle-able either by the user or by the server configuration. For us this is mostly a nuisance that slows us down (a bit) 😅

ainoam commented 2 years ago

@idantene What is more bothersome for your team? The lack of "click task to open panel"? "click task to close panel"? both equally?

idantene commented 2 years ago

More so that we have to right-click a task and choose "detailed view" (or choose it from the WebUI). On a personal note, I don't really understand why the UX changed in that regard. If the user wants to select a task specifically and not view it, they have the little check box on the left-hand side. Then again, I'm sure there are users who find this more comfortable. At least letting the user/server admin choose the desired behaviour would be nice then :)

mctigger commented 2 years ago

I agree, but I do not think there are any users who find that more comfortable. Now there is just the same action when pressing left or right mouse button. Previously left = mark/menu, right=details. There is literally no upside to this change.

ainoam commented 2 years ago

@idantene @mctigger No doubt different usage patterns can be differently affected by this change. How often do you find yourselves switching between table view and detail view? Is one view significantly predominant? How often do you use other UI task actions (i.e. other context menu items, or even for batch actions)?

idantene commented 2 years ago

@idantene @mctigger No doubt different usage patterns can be differently affected by this change. How often do you find yourselves switching between table view and detail view? Is one view significantly predominant? How often do you use other UI task actions (i.e. other context menu items, or even for batch actions)?

Almost always in detail view here; rarely use any UI task actions other than archiving, sorting, or filtering. While I'm 100% on @mctigger's side here, I do see a use-case for this default behaviour (e.g. if a team is more inclined to continuously select multiple tasks, it might more convenient to click on the tasks rather than the small checkbox) -- but I would gamble this is probably a minority of the user base.

H4dr1en commented 2 years ago

I understand the new UX, but it would be nice if this feature was toggle-able either by the user or by the server configuration. For us this is mostly a nuisance that slows us down (a bit) 😅

I support this, I am in the same situation 👍

VladimirYugayKaia commented 2 years ago

I understand the new UX, but it would be nice if this feature was toggle-able either by the user or by the server configuration. For us this is mostly a nuisance that slows us down (a bit) 😅

Second this as well!

ainoam commented 2 years ago

@mctigger @idantene @H4dr1en @VladimirYugayKaia First and foremost, thanks for your excellent feedback - Much appreciate you taking the time to provide it. Since the webapp "remembers" the table mode (i.e. if you go to details view - that's what you get everytime you got to the experiments page, until you switch), the main hindrance is in getting to this mode (using the table header mode button, or through an experiment's context menu) - Did I get it right?

erezalg commented 2 years ago

Hi @mctigger @idantene @H4dr1en @VladimirYugayKaia,

Trying to wrap the discussion up and finalize conclusions, please let me know if I got it right:

  1. The annoying part is to get to the "detailed" view right? Or is it the transition between table view and detailed view?
  2. Would a simple setting that allows you to choose between old and new behavior solve the issue? From what I understand the answer is positive but just double checking!

Thanks a lot for the help!

mctigger commented 2 years ago

@erezalg

  1. Yes
  2. You make it too complicated. Just bring back the old behavior.

Currently: Left-Click --> Highlights row --> Context Menu --> Details (this is what I hate) Right-Click --> Context Menu --> Details

Old behavior: Currently: Left-Click --> Details (this is what I love) Right-Click --> Context Menu --> Details (same behavior as current)

There is no need for an additional setting, everyone was happy with the old behavior since it is a superset of the current.

idantene commented 2 years ago

Hi @mctigger @idantene @H4dr1en @VladimirYugayKaia,

Trying to wrap the discussion up and finalize conclusions, please let me know if I got it right:

  1. The annoying part is to get to the "detailed" view right? Or is it the transition between table view and detailed view?
  2. Would a simple setting that allows you to choose between old and new behavior solve the issue? From what I understand the answer is positive but just double checking!

Thanks a lot for the help!

Extending @mctigger's answer:

  1. Yes
  2. Sure, but ideally the default is the old behaviour; I'm 100% on board with giving users the freedom to control their own UI/UX.
ainoam commented 2 years ago

Hey @mctigger @idantene @H4dr1en @VladimirYugayKaia,

Floating a new idea we're considering - keeping the current behaviour: Left-Click --> Highlights row --> Context Menu --> Details Right-Click --> Context Menu --> Details

and adding Left-Double-Click --> Details

How would this strike you? In such a case, what would you expect for the "Left-Double-Click" do when in "Details" mode? a. Go back to Table view b. Go to Full-Screen view c. Something else?

Appreciate your thoughts!

idantene commented 2 years ago

What does highlighting a row yield? Why would one need to highlight a row when they can use the checkbox next to the experiment?

I think this may be an interesting compromise, but would still prefer letting the user choose their desired way of interaction.

On Sun, 3 Jul 2022, 19:29 Noam Wasersprung, @.***> wrote:

Hey @mctigger https://github.com/mctigger @idantene https://github.com/idantene @H4dr1en https://github.com/H4dr1en @VladimirYugayKaia https://github.com/VladimirYugayKaia,

Floating a new idea we're considering - keeping the current behaviour: Left-Click --> Highlights row --> Context Menu --> Details Right-Click --> Context Menu --> Details

and adding Left-Double-Click --> Details

How would this strike you? In such a case, what would you expect for the "Left-Double-Click" do when in "Details" mode? a. Go back to Table view b. Go to Full-Screen view c. Something else?

Appreciate your thoughts!

— Reply to this email directly, view it on GitHub https://github.com/allegroai/clearml-server/issues/134#issuecomment-1173131581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC46YKUDB7KYCYPIEMPXVPLVSG5XBANCNFSM5UOLQOLA . You are receiving this because you were mentioned.Message ID: @.***>

ainoam commented 2 years ago

@idantene

Good news - The next version of the ClearML server should provide for double-click to open details view.

What does highlighting a row yield? Why would one need to highlight a row when they can use the checkbox next to the experiment?

There actually is a slight difference, where row-click selects this row only, where as using the checkbox adds to the existing row selection.

idantene commented 2 years ago

Good news - The next version of the ClearML server should provide for double-click to open details view.

Hurray for some updates 🎉

There actually is a slight difference, where row-click selects this row only, where as using the checkbox adds to the existing row selection.

I understand the difference - I don't understand where the use of highlighting a single row (and not adding it) comes into place?

Also @ainoam, maybe too little too late, but in response to your question -

In such a case, what would you expect for the "Left-Double-Click" do when in "Details" mode? a. Go back to Table view b. Go to Full-Screen view c. Something else?

I still very strongly think the default behaviour of single click is better, but if hard-pressed for this, I would imagine double-click would toggle between table and details view.

idantene commented 2 years ago

@ainoam

I think a more intuitive flow is the following: Left click -> toggle details/table view Right click -> context menu Left double click -> Toggle full screen (i.e. table view -> full screen detailed view -> table view, and detailed view -> full screen detailed view -> detailed view)

This is more consistent with other UIs I believe.

What do you think @mctigger @H4dr1en @VladimirYugayKaia ?

pollfly commented 2 years ago

Hey @mctigger! v1.7.0 is now out supporting switching to details mode through a double-click.

jkhenning commented 1 year ago

Closing this issue. Please reopen if it's still relevant.