allegroai / clearml-server

ClearML - Auto-Magical CI/CD to streamline your AI workload. Experiment Management, Data Management, Pipeline, Orchestration, Scheduling & Serving in one MLOps/LLMOps solution
https://clear.ml/docs
Other
386 stars 134 forks source link

Invalid mongodb connection string if CLEARML_MONGODB_SERVICE_CONNECTION_STRING is specified #252

Open smartnet-club opened 2 months ago

smartnet-club commented 2 months ago

CLEARML_MONGODB_SERVICE_CONNECTION_STRING=mongodb://myDBReader:D1fficultP%40ssw0rd@mongodb0.example.com:27017/?authSource=admin

expected connection string: mongodb://myDBReader:D1fficultP%40ssw0rd@mongodb0.example.com:27017/auth?authSource=admin

actual connection string: mongodb://myDBReader:D1fficultP%40ssw0rd@mongodb0.example.com:27017/?authSource=admin/auth

must be fixed database package con_str = f"{override_connection_string.rstrip('/')}/{key}"

ainoam commented 2 months ago

Thanks for letting us know @smartnet-club - We'll take a look.

evg-allegro commented 2 months ago

@smartnet-club We reproduced the issue. It will be fixed in the upcoming open source version (v1.17)