search

allenai / ScienceWorld

ScienceWorld is a text-based virtual environment centered around accomplishing tasks from the standardized elementary science curriculum.
https://sciworld.apps.allenai.org/
Apache License 2.0
199 stars 24 forks source link

Store library version in only a single place #42

Closed aphedges closed 1 year ago

aphedges commented 1 year ago

This PR should hopefully remove all of the internal version mismatch issues that have been happening. See the commit messages for more details.

I was able to use the following commands to install the library without any issues:

# From the root of this repository on macOS
pip install -e .
# In other environments on both Linux and macOS
pip install -U 'scienceworld @ git+https://github.com/allenai/ScienceWorld.git@095562cc21eeb71bd21a8a2fd2533a6f82078d6d'

I used the following command to ensure the version could be retrieved properly:

python -c 'import scienceworld; print(scienceworld.version.__version__)'
MarcCote commented 1 year ago

Thanks for the PR. I've tested locally and confirm it works as intended. It can even deal with rc releases :+1:.

aphedges commented 1 year ago

@MarcCote, I'm glad it works for you. Thanks for merging!