allenai / ScienceWorld

ScienceWorld is a text-based virtual environment centered around accomplishing tasks from the standardized elementary science curriculum.
https://sciworld.apps.allenai.org/
Apache License 2.0
199 stars 24 forks source link

Improve task name handling #46

Closed aphedges closed 1 year ago

aphedges commented 1 year ago

Building off the work in #44, I've made some improvements to the handling of task names while hopefully maintaining backwards compatibility.

The new file tasks.json was generated using the files in json_creation.zip:

I didn't actually test my changes by running ScienceWorld, but the tests make me pretty confident it would work.

PeterAJansen commented 1 year ago

In retrospect, it seems like referencing the tasks by either the ID in the paper (e.g. "3-1") or their detailed name (e.g. "create-a-circuit") is the way to go, since it makes sure there's no ambiguity. The 0-29 numbering that's auto-sorted seemed great in development, but seems less great in retrospect. :)

MarcCote commented 1 year ago

@aphedges thank you again. I'll make a new patch release (1.1.3) today.