allfed / allfed-integrated-model

Integrated model to calculate the effects of resilient foods in catastrophic events
https://allfed.github.io/allfed-integrated-model/
GNU General Public License v3.0
11 stars 10 forks source link

KOR/PRK confusion #124

Closed simonblouin closed 2 months ago

simonblouin commented 9 months ago

There is a mix up somewhere between North Korea and South Korea. The computer_readable_combined.csv file has the following lines:

KOR,Democratic People's Republic of Korea,...
PRK,Republic of Korea,...

It should be the other way around (KOR = Republic of Korea). Some data from the KOR line seems to relate to South Korea and other to North Korea: to solve this problem, one needs to look closely at the different data sources to identify the error(s).

lukaszgajewski commented 3 months ago

It seems to me that the issue is in this file (virtually all tabs), and this file. In the latter it's the iso3_no_EU_GBR_TWN variable (PRK/KOR ordering needs swapped), although we might want to refactor that whole thing entirely because to me it seems completely unnecessarily complicated.