search

allo- / feedjack

Feedparser-based feed aggregation django app
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Simplify Theming #3

Open allo- opened 8 years ago

allo- commented 8 years ago

Create a good HTML template and delegate all theming to CSS files.

allo- commented 8 years ago

related: https://github.com/allo-/feedjack/issues/13

allo- commented 8 years ago

[ ] Theming via a path to a CSS-File in a config. [ ] Full themes via additional packages with templates overriding HTML files using the TEMPLATE_DIRS search path. They can extend the default theme using django-apptemplates

allo- commented 8 years ago

CSS themes are reasonable, but there is nothing which would prevent full themes bringing their own base.html and all other needed files. They may be put in the TEMPLATE_DIRS by the admin or installed via pip as feedjack-theme-x package, as long as render("feedjack/{0}/file.html".format(themename)) works.

Still using the formatstring seems a reasonable choice to allow per-site and per-user theme choice.

Maybe the themes will be moved into a ``themes subfolder to have more general html snippets in the main path.

Old themes should be adapted, once the template and url structure is fixed again: https://github.com/allo-/feedjack/issues/18.