Closed leruaa closed 1 month ago
While attempting to apply this refactoring to alloy itself, I start to understand why the k256
feature is not additive. That to avoid to impl traits like SignableTransaction for multiple Signature types leading to the "multiple impl
s ... found" error.
I'm trying to find a workaround.
@leruaa perhaps we can introduce a helper trait in alloy for the required rsv function and just that for the alloy encode signature fns instead?
but perhaps we should consider removing the generic entirely, I find this very useless because this is effectively just duplicating the rsv again
@mattsse fyi and for posterity, the branch in alloy applying this refactoring in alloy-core: https://github.com/alloy-rs/alloy/compare/main...leruaa:alloy:signature_refactoring
Motivation
Needed for https://github.com/alloy-rs/alloy/issues/1077 and https://github.com/paradigmxyz/reth/pull/9593
Solution
PR Checklist