search

almende / vis

⚠️ This project is not maintained anymore! Please go to https://github.com/visjs
7.86k stars 1.48k forks source link

ember addons #3074

Open gossi opened 7 years ago

gossi commented 7 years ago

Hey there,

I do used the ember-addon ember-cli-visjs by by @Suven. Well actually it only supported the network and I was looking for the timeline, so I used some of the concepts from there and write my own components for the timeline. At the moment, they are private, yet I would like to publish them in regards to a greater effort, the question is where? I read somewhere that - I guess in combination with a possible split of the library, see #2405 - it is planned to create a github org for it and also provide packages for current frameworks including visjs. I would consider this the right location for those packages. I could image the following ember-packages:

while common/shared functionality sticks in ember-vis(-core) (and would only be a dependency of the others) an end-user might only install ember-vis-timeline (or whatever they need).

Would like to hear your thoughts :)

bradh commented 7 years ago

Is there a reason why you don't merge back to the parent project instead of making a fork?

gossi commented 7 years ago

They stick with my private project at the moment, though I would like to extract them into their own project to publish them. The code basically is pretty much independent of the mentioned ember-addon (though some common classes can be identified, what I classified as core). Also mentioning a possible split of the library, I was wondering what might be the best place to push my code to.

@wimrijnders it is less of a "Feature Request" more like a discussion where to provide code :)

If a github organisation for vis is created, it would this the best place for it.

wimrijnders commented 7 years ago

@gossi 'Feature Request' for want of a better label! I'm pretty sure it's not a bug and it's not a user question, so this by elimination.

gossi commented 7 years ago

Looks like, there is more code ready to be published for general terms. What about already collecting code for the ember-addons over at @visjs? /cc @mojoaxel @josdejong @nightsh @Suven