search

almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 47 forks source link

Update `embedded-hal` to `1.0.0` and `display-interface` to `0.5.0` #104

Closed markszente closed 4 months ago

markszente commented 5 months ago

The examples have not been updated. I can probably do the ESP32-C3 one, and possibly the RP Pico as well. However, I cannot do the Zero W.

rfuest commented 5 months ago

We will need to bump our MSRV to 1.75.0, because display-interface 0.5 does require at least that Rust version.

almindor commented 4 months ago

@markszente thank you! you ninjad me on this :D Is it ready for review? I think it's good atm.

almindor commented 4 months ago

Spoke too soon, the CI needs updating to MSRV 1.75 too

markszente commented 4 months ago

@almindor I haven't touched the examples yet, so, I don't know. I hope to have some time for them later this week if they need updating. And yeah the CI too.

markszente commented 4 months ago

Okay I guess the CI is taken care of

rfuest commented 4 months ago

IMO we should merge this first and handle the examples in another PR. At least some of them were already broken before this PR. And perhaps we should also look into building the examples in CI, which is also outside the scope of this PR.

almindor commented 4 months ago

@rfuest Agreed, merged this as-is we should fix up the examples (at least on paper, I know none of us have all the MCUs) in a separate PR before going for a release

rfuest commented 4 months ago

I just realized a problem with building the examples in CI. The examples depend on the latest release of mipidsi and not on the current state of the master branch. Should we change the examples to use a path dependency instead?

almindor commented 4 months ago

I just realized a problem with building the examples in CI. The examples depend on the latest release of mipidsi and not on the current state of the master branch. Should we change the examples to use a path dependency instead?

Yes, I think we should do that as part of the fixes.