search

almondtools / testrecorder

Create Test Fixtures from Runnable Java Code
http://testrecorder.amygdalum.net/
GNU Lesser General Public License v3.0
51 stars 5 forks source link

Some minor improvements #58

Closed rusio closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     92.82%   92.82%           
  Complexity     2707     2707           
=========================================
  Files           244      244           
  Lines          7487     7487           
  Branches        928      928           
=========================================
  Hits           6950     6950           
  Misses          352      352           
  Partials        185      185

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47c510a...d3156f2. Read the comment docs.

almondtools commented 6 years ago

Thanks for your contribution, especially for reviewing the documentation.

I yet do not completely agree with your modification to files. I assume that on your local system you get test errors. Yet I would locate the failure in a wrong assertion (i.e. containsExactly should have been containsExactlyInAnyOrder), do you agree?

rusio commented 6 years ago

containsExactly should have been containsExactlyInAnyOrder

Yes, this should be good

almondtools commented 6 years ago

I merged your changes manually. Please report when the problem with file sorting persists.