Support for Roslyn nullable annotations

aloneguid / parquet-dotnet

Fully managed Apache Parquet implementation

https://aloneguid.github.io/parquet-dotnet/

MIT License

637 stars 153 forks source link

Support for Roslyn nullable annotations #537

Closed ErikApption closed 2 months ago

ErikApption commented 4 months ago

This is a fix for bug #535. The current parquet.net doesn't leverage compiler nullable when checking if members are nullable. This affects all classes - so any string property was marked as nullable in the schema. This PR adds checks for Roslyn's annotations to ensure that a field is nullable.

Added checks for roslin compiler attributes to properly identify nullable and not nullable classes
Added supporting unit tests

aloneguid commented 2 months ago

Sorry, will have to revert this as it changes default behavior. My bad, I missed it during PR review.

ErikApption commented 1 month ago

I could look at revising this pr to disable nullable support by default but any chances to consider changing the default in version 5? Working with files that are not generated by parquet.net is not intuitive without nullable support. There might be a compromise to limit issues and load null values into non nullable fields and simply show a warning.