alphagov / content-publisher

Publishing application for GOV.UK
https://docs.publishing.service.gov.uk/apps/content-publisher.html
MIT License
33 stars 11 forks source link

Fix footer links #3149

Closed ChrisBAshton closed 2 months ago

ChrisBAshton commented 4 months ago

These footer links have been broken since version 37.1.1 of govuk_publishing_components, which automatically converts all footer links to absolute URLs, using Plek.new.website_root: https://github.com/alphagov/govuk_publishing_components/pull/3699

That corresponds to https://www.gov.uk on Production, but needs to be https://content-publisher.publishing.service.gov.uk.

No other publishing app passes custom links to the footer like Content Publisher does, so this appears to be the only app affected. With that in mind, the simplest fix is to specify the correct absolute URL rather than deferring to the component (as opposed to, say, changing the value of Plek.new.website_root, which may have unintended side-effects).

Tested in a Rails console on Production:

"#{Plek.external_url_for('content-publisher')}#{app.guidance_path}"
=> "https://content-publisher.publishing.service.gov.uk/documents/publishing-guidance"

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.