search

alphagov / govuk-docker

GOV.UK development environment using Docker 🐳
MIT License
82 stars 22 forks source link

Add redis config to docker #621

Closed leenagupte closed 2 years ago

leenagupte commented 2 years ago

Testing a change to how Redis is called in LLM failed because the Redis config is missing.

The "check-links" rake task failed with the following:

govuk-docker-run bundle exec rake check-links
docker-compose -f [...] run local-links-manager-lite bundle exec rake check-links
Creating govuk-docker_local-links-manager-lite_run ... done
rake aborted!
Redis::CannotConnectError: Cannot assign requested address - connect(2) for [::1]:6379
/govuk/local-links-manager/app/lib/local_links_manager/distributed_lock.rb:16:in `lock'
/govuk/local-links-manager/lib/tasks/check-links/link_checker.rake:7:in `block in <top (required)>'
/root/.rbenv/versions/2.7.6/bin/bundle:23:in `load'
/root/.rbenv/versions/2.7.6/bin/bundle:23:in `<main>'

Redis config already exists in govuk-puppet, so it looks like this was just missed previously.

1pretz1 commented 2 years ago

Thanks for working on this! Do we also need to add redis as a dependency for lite and app? E.g https://github.com/alphagov/govuk-docker/blob/main/projects/static/docker-compose.yml#L28

leenagupte commented 2 years ago

Thanks for working on this! Do we also need to add redis as a dependency for lite and app? E.g https://github.com/alphagov/govuk-docker/blob/main/projects/static/docker-compose.yml#L28

Good spot! I've updated and fixed up.