search

alphagov / govuk-frontend

GOV.UK Frontend contains the code you need to start building a user interface for government platforms and services.
https://frontend.design-system.service.gov.uk/
MIT License
1.17k stars 320 forks source link

Fix divider width for small checkboxes #5114

Closed colinrotherham closed 2 months ago

colinrotherham commented 2 months ago

Hello 👋

There might be some history behind this, but I noticed small checkboxes use the regular divider width (unlike radios)

This PR ensures checkboxes follow the same convention as radios and adds a new example

Before

Before, small checkboxes without adjustments to divider width and margin

After

After, small checkboxes with adjustments to divider width and margin

History

  1. Dividers supported for Radios in GOV.UK Elements
  2. Dividers added to Radios in GOV.UK Frontend via PR #849
  3. Smaller Radios and Checkboxes added in PR #1125 with narrow divider widths in https://github.com/alphagov/govuk-frontend/pull/1125/commits/b645ac16c5c802e6a3a53125ac588166a8d20872
  4. Dividers added to Checkboxes in GOV.UK Frontend via PR #2151 without narrow divider widths

Worth mentioning existing comments regarding divider widths:

And a similar mention of label wrapping (which affects dividers too)

colinrotherham commented 2 months ago

Thanks @owenatgov @domoscargin

Would you and the team mind adding a changelog entry please?

Always feels strange writing my own thank you message