Investigate whether it's worth building a separate dist folder to upload to GitHub or if we could provide the built files for each release a different way (eg. uploading the package uploaded to npm).
It's worth noting that beyond the complexity, the dist folder also gets a diff commented on the PRs that have changes to dist. This allows us to review that no unexpected code gets bundled in GOV.UK Frontend, so we'll need to make sure we can keep doing so.
In addition, since #4240, the package contains all the files that are shipped in dist: both the minified CSS and JS and the assets. This brings to question whether we need to make a full build to create dist.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
[ ] We've assessed if we still needed to build dist separately and made a decision about it.
What
Investigate whether it's worth building a separate
distfolder to upload to GitHub or if we could provide the built files for each release a different way (eg. uploading the package uploaded to npm).It's worth noting that beyond the complexity, the
distfolder also gets a diff commented on the PRs that have changes todist. This allows us to review that no unexpected code gets bundled in GOV.UK Frontend, so we'll need to make sure we can keep doing so.Why
Having a separate Zip file uploaded to GitHub means we're maintaining a separate build process for creating it. This expands the possibility for breakage, in order to produce something that's not meant for use in production as we explicitely state in our documentation.
In addition, since #4240, the package contains all the files that are shipped in
dist: both the minified CSS and JS and the assets. This brings to question whether we need to make a full build to createdist.Who needs to work on this
Developers
Who needs to review this
Developers
Done when
distseparately and made a decision about it.