alphagov / learningtime-hh-sem1-gov-location-service

Early talent assigned learning time, Semester 1 project for Harley Harris
1 stars 1 forks source link

Remove core business logic from controller to unbloat it #34

Closed harley-harris closed 1 year ago

harley-harris commented 1 year ago
harley-harris commented 1 year ago

@antoni-devlin - i did initially think about splitting up the changes related to the API, and went with that approach initially. But I found the logic to be very similar between the services and the logic is very simple. So in this case I think it's better to keep them as one commit. Also, the second API call relies on the value returned from the first call, so I think it's better to keep the changes coupled together. @huwd might have more comments?

The tsconfig change should defo be a separate commit, so I will split that out.

Thanks for the review!