search

alphagov / notifications-net-client

.NET client for the GOV.UK Notify API
https://www.nuget.org/packages/GovukNotify/
MIT License
25 stars 20 forks source link

Cancellation support for async methods #176

Open euantorano opened 1 year ago

euantorano commented 1 year ago

It would be very useful if the various *Async methods could optionally take a CancellationToken to cancel the send operation.

samuelhwilliams commented 1 year ago

Hey Euan 👋

Thanks for raising an issue on this so we can track it.

We don't have any outright .NET members on our team currently, which makes prioritising this work a bit harder. We would be very keen to facilitate the Notify .NET community in working on improvements such as this independently, though. If you have the capability to put up a pull request implementing the feature we'd be very happy to help get it reviewed and released :)

euantorano commented 1 year ago

Hi Samuel,

Thanks for the speedy response. I'll see what we can do depending on resources and time, but glad to know you're open to pull requests.