search

alphanodes / additional_tags

Redmine Plugin for adding tags functionality to issues and wiki pages.
https://www.redmine.org/plugins/additional_tags
GNU General Public License v2.0
65 stars 26 forks source link

problem after update from redmineup_tags #52

Open rkteam opened 1 year ago

rkteam commented 1 year ago

After upgrading from redmineup_tags to this plugin, we have a problem with saved issue queries that had tags in the condition.

The problem is: redmineup_tags use "issue_tags" for field "filters" in IssueQuery additional_tags use "tags" for field "filters" in IssueQuery So if you save issue query with "tags" in filters and update to additional_tags you will get error 500 on this query. It is not big problem because you can go to /queries/__query_id__/edit and edit it. But big problem if you use this query in "my page". My page totally broken and you cannot fix it without edit directly in database.

I see 2 ways to fix it:

  1. create migration that edit all saved queries.
  2. refactor additional_tags and change "tags" to "issue_tags" (i think it will fix #48 #50 also)

I can do it myself but I want ask developers: which way is better?

alexandermeindl commented 1 year ago

Hi @rkteam,

would be great if you can provide a PR for your first option (migrate existing saved queries).

Note: some filters with redmineup_tags works different. E.g. multiple tags uses AND operation. This means, only renaming is not enough for a 100% migration.