alphapapa / org-super-agenda

Supercharge your Org daily/weekly agenda by grouping items
GNU General Public License v3.0
1.38k stars 108 forks source link

Change default value of `org-super-agenda-header-properties` (Fix #236) #237

Closed casch-at closed 1 year ago

casch-at commented 1 year ago

This should fix it.

My setup.

(use-package org-super-agenda
    :defer nil
    :init
    (defun org-super-agenda-toggle ()
      "Toggle `org-super-agenda-mode' and refresh `org-agenda' buffers."
      (interactive)
      (org-super-agenda-mode (if org-super-agenda-mode -1 1))
      (org-agenda-redo-all t))
    :config
    (setq org-super-agenda-hide-empty-groups t
          org-super-agenda-groups
          '((:name "Daily Note" :tag "NOTE" :face)
            (:log t)
            (:time-grid t)
            (:name "Important" :priority "A" :face)
            (:order-multi (100
                           (:name "Someday/Maybe" :tag "SM")
                           (:name "Anniversaries" :category "Anniversa.")))
            (:order-multi (2
                           (:name "Projects" :tag "PROJECT")
                           (:name "Computer" :category "Computer")
                           (:name "Home" :category "Home")
                           (:name "Errand" :category "Errand")
                           (:name "Talk" :tag "TALK")
                           (:name "Read and Learn" :category "Study")
                           (:name "Miscellaneous" :category "Misc")
                           (:name "Health" :category "Health")
                           (:name "Phone" :tag "PHONE")))
            (:name "Waiting" :todo "WAITING" :order 8)))
    (org-super-agenda-mode t))
casch-at commented 1 year ago

Hmm, it will be added as a text-property, see https://github.com/alphapapa/org-super-agenda/pull/237/files#diff-1bf688f5ac9c70a3a9acbf9a61bea3b32e4936c2b0303550ec5336676922265fR312

In both cases the C function add-text-properties-1 will be called :-| So it should lead to the same result. When I call describe-char on the header I still see the face property.

Adam Porter @.***> writes:

This change would no longer apply the face org-super-agenda-header to the section headers. That's not what we want to do, is it?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

casch-at commented 1 year ago

Hey @alphapapa, should I make any changes for it to be merged?

alphapapa commented 1 year ago

Thanks for your patience. BTW, always feel free to ping me on issues like this if I overlook or forget about them.