search

alphapapa / org-web-tools

View, capture, and archive Web pages in Org-mode
GNU General Public License v3.0
647 stars 33 forks source link

Update obsolete utility calls #58

Closed fade closed 1 year ago

fade commented 1 year ago

few trivial updates to squash load-time warnings due to obsolete identifiers. I've tested on emacs 29.1 and on a build of emacs HEAD as of Monday September 4, 2023. Org mode version 9.7-pre (release_9.6.8-747-gf6fc38).

now, I am not well versed in the mechanics of maintaining a package that needs to be backwards compatible to some arbitrary point in the past, so this may not be welcome. If this is the case, I'd appreciate a comment on the procedure for this kind of maintenance. :)

Best regards

alphapapa commented 1 year ago

Hi Brian,

Thanks for noticing these and submitting the PR. It can be challenging to keep up with the symbol renaming that tends to happen upstream. Generally it's necessary to do conditional aliases, like this (or similar for variables), which isn't fun.

Rather than digging through Org's history to find out when those variables were renamed, I pushed my makem.sh scripts and CI configuration, and enabled it for PRs, configuring it to run on the most recent major releases. The linter in the GitHub Actions CI should identify where the problem begins, in terms of Emacs versions...

alphapapa commented 1 year ago

I pushed a nearly no-op commit to the branch to make CI run on it...

https://github.com/alphapapa/org-web-tools/actions/runs/6101596781/job/16558260847

alphapapa commented 1 year ago

Lines like this are what we're looking for: https://github.com/alphapapa/org-web-tools/actions/runs/6101596781/job/16558261020#step:6:99 (Thanks to package-lint)

alphapapa commented 1 year ago

@fade Thanks again for submitting this. In the process of tidying up master I inadvertently made some changes that were already made in this branch by you, so I marked you as a co-author of those commits, then rebased and merged this branch.

fade commented 1 year ago

Very kind. Thanks. I'm glad they were out some use.