search

alphaville / ToxOtis

An HTTP client for consuming OpenTox predictive toxicology web services.
http://opentox.ntua.gr/wiki
6 stars 1 forks source link

Separation of abstraction layers (abstract classes, interfaces) in the 'core' package #15

Closed alphaville closed 13 years ago

alphaville commented 13 years ago

Create different package for implementations (say org.opentox.toxotis.core.impl) and let the core package contain just interfaces and abstract classes.

hampos commented 13 years ago

I dissagree with that issue. I believe the architecture you propose is deprecated and should not be used.

alphaville commented 13 years ago

There was a scuffle of a score of Classes (17 classes) in the package org.opentox.toxotis.core so I thought it would be good to separate the components like Algorithm from Abstraction Layers like OTComponent or IStAXWritable. It doesn't make any difference in employing these classes elsewhere in the source code; it's just a refactoring to make things more clear and unambiguous...

hampos commented 13 years ago

My dissagreement was out of scope. Please proceed with refactoring as desired.

alphaville commented 13 years ago

Done!